mirror of
https://gitee.com/hhyykk/ipms-sjy.git
synced 2025-08-11 00:31:52 +08:00
拼团活动:完善 review 提到的问题
This commit is contained in:
@@ -2,6 +2,7 @@ package cn.iocoder.yudao.module.promotion.controller.app.activity;
|
||||
|
||||
import cn.hutool.core.collection.CollUtil;
|
||||
import cn.hutool.core.map.MapUtil;
|
||||
import cn.iocoder.yudao.framework.common.enums.CommonStatusEnum;
|
||||
import cn.iocoder.yudao.framework.common.pojo.CommonResult;
|
||||
import cn.iocoder.yudao.module.promotion.controller.app.activity.vo.AppActivityRespVO;
|
||||
import cn.iocoder.yudao.module.promotion.dal.dataobject.bargain.BargainActivityDO;
|
||||
@@ -21,12 +22,10 @@ import org.springframework.web.bind.annotation.RequestParam;
|
||||
import org.springframework.web.bind.annotation.RestController;
|
||||
|
||||
import javax.annotation.Resource;
|
||||
import java.util.ArrayList;
|
||||
import java.util.HashMap;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
import java.util.*;
|
||||
|
||||
import static cn.iocoder.yudao.framework.common.pojo.CommonResult.success;
|
||||
import static cn.iocoder.yudao.framework.common.util.collection.CollectionUtils.convertMultiMap;
|
||||
|
||||
@Tag(name = "用户 APP - 营销活动") // 用于提供跨多个活动的 HTTP 接口
|
||||
@RestController
|
||||
@@ -42,59 +41,72 @@ public class AppActivityController {
|
||||
private BargainActivityService bargainActivityService;
|
||||
|
||||
@GetMapping("/list-by-spu-id")
|
||||
@Operation(summary = "获得单个商品,近期参与的每个活动") // 每种活动,只返回一个
|
||||
@Operation(summary = "获得单个商品,近期参与的每个活动")
|
||||
@Parameter(name = "spuId", description = "商品编号", required = true)
|
||||
public CommonResult<List<AppActivityRespVO>> getActivityListBySpuId(@RequestParam("spuId") Long spuId) {
|
||||
return success(getAppActivityRespVOList(spuId));
|
||||
// 每种活动,只返回一个
|
||||
return success(getAppActivityRespVOList(Collections.singletonList(spuId)));
|
||||
}
|
||||
|
||||
@GetMapping("/list-by-spu-ids")
|
||||
@Operation(summary = "获得多个商品,近期参与的每个活动") // 每种活动,只返回一个;key 为 SPU 编号
|
||||
@Operation(summary = "获得多个商品,近期参与的每个活动")
|
||||
@Parameter(name = "spuIds", description = "商品编号数组", required = true)
|
||||
public CommonResult<Map<Long, List<AppActivityRespVO>>> getActivityListBySpuIds(@RequestParam("spuIds") List<Long> spuIds) {
|
||||
if (CollUtil.isEmpty(spuIds)) {
|
||||
return success(MapUtil.empty());
|
||||
}
|
||||
|
||||
// TODO @puhui999:要避免这种 1+n 的查询
|
||||
Map<Long, List<AppActivityRespVO>> map = new HashMap<>(spuIds.size());
|
||||
spuIds.forEach(spuId -> {
|
||||
map.put(spuId, getAppActivityRespVOList(spuId));
|
||||
});
|
||||
return success(map);
|
||||
// 每种活动,只返回一个;key 为 SPU 编号
|
||||
return success(convertMultiMap(getAppActivityRespVOList(spuIds), AppActivityRespVO::getSpuId));
|
||||
}
|
||||
|
||||
private List<AppActivityRespVO> getAppActivityRespVOList(Long spuId) {
|
||||
private List<AppActivityRespVO> getAppActivityRespVOList(Collection<Long> spuIds) {
|
||||
if (CollUtil.isEmpty(spuIds)) {
|
||||
return new ArrayList<>();
|
||||
}
|
||||
|
||||
List<AppActivityRespVO> activityList = new ArrayList<>();
|
||||
// 拼团活动
|
||||
CombinationActivityDO combination = combinationActivityService.getCombinationActivityBySpuId(spuId);
|
||||
if (combination != null) {
|
||||
activityList.add(new AppActivityRespVO()
|
||||
.setId(combination.getId())
|
||||
.setType(PromotionTypeEnum.COMBINATION_ACTIVITY.getType())
|
||||
.setName(combination.getName())
|
||||
.setStartTime(combination.getStartTime())
|
||||
.setEndTime(combination.getEndTime()));
|
||||
List<CombinationActivityDO> combinationActivities = combinationActivityService.getCombinationActivityBySpuIdsAndStatus(
|
||||
spuIds, CommonStatusEnum.ENABLE.getStatus());
|
||||
if (CollUtil.isNotEmpty(combinationActivities)) {
|
||||
combinationActivities.forEach(item -> {
|
||||
activityList.add(new AppActivityRespVO()
|
||||
.setId(item.getId())
|
||||
.setType(PromotionTypeEnum.COMBINATION_ACTIVITY.getType())
|
||||
.setName(item.getName())
|
||||
.setSpuId(item.getSpuId())
|
||||
.setStartTime(item.getStartTime())
|
||||
.setEndTime(item.getEndTime()));
|
||||
});
|
||||
}
|
||||
// 秒杀活动
|
||||
SeckillActivityDO seckill = seckillActivityService.getSeckillActivityBySpuId(spuId);
|
||||
if (seckill != null) {
|
||||
activityList.add(new AppActivityRespVO()
|
||||
.setId(seckill.getId())
|
||||
.setType(PromotionTypeEnum.SECKILL_ACTIVITY.getType())
|
||||
.setName(seckill.getName())
|
||||
.setStartTime(seckill.getStartTime())
|
||||
.setEndTime(seckill.getEndTime()));
|
||||
List<SeckillActivityDO> seckillActivities = seckillActivityService.getSeckillActivityBySpuIdsAndStatus(
|
||||
spuIds, CommonStatusEnum.ENABLE.getStatus());
|
||||
if (CollUtil.isNotEmpty(seckillActivities)) {
|
||||
seckillActivities.forEach(item -> {
|
||||
activityList.add(new AppActivityRespVO()
|
||||
.setId(item.getId())
|
||||
.setType(PromotionTypeEnum.SECKILL_ACTIVITY.getType())
|
||||
.setName(item.getName())
|
||||
.setSpuId(item.getSpuId())
|
||||
.setStartTime(item.getStartTime())
|
||||
.setEndTime(item.getEndTime()));
|
||||
});
|
||||
}
|
||||
// 秒杀活动
|
||||
BargainActivityDO bargain = bargainActivityService.getBargainActivityBySpuId(spuId);
|
||||
if (bargain != null) {
|
||||
activityList.add(new AppActivityRespVO()
|
||||
.setId(bargain.getId())
|
||||
.setType(PromotionTypeEnum.BARGAIN_ACTIVITY.getType())
|
||||
.setName(bargain.getName())
|
||||
.setStartTime(bargain.getStartTime())
|
||||
.setEndTime(bargain.getEndTime()));
|
||||
// 砍价活动
|
||||
List<BargainActivityDO> bargainActivities = bargainActivityService.getBargainActivityBySpuIdsAndStatus(
|
||||
spuIds, CommonStatusEnum.ENABLE.getStatus());
|
||||
if (CollUtil.isNotEmpty(bargainActivities)) {
|
||||
bargainActivities.forEach(item -> {
|
||||
activityList.add(new AppActivityRespVO()
|
||||
.setId(item.getId())
|
||||
.setType(PromotionTypeEnum.BARGAIN_ACTIVITY.getType())
|
||||
.setName(item.getName())
|
||||
.setSpuId(item.getSpuId())
|
||||
.setStartTime(item.getStartTime())
|
||||
.setEndTime(item.getEndTime()));
|
||||
});
|
||||
}
|
||||
return activityList;
|
||||
}
|
||||
|
@@ -13,12 +13,14 @@ public class AppActivityRespVO {
|
||||
private Long id;
|
||||
|
||||
@Schema(description = "活动类型", requiredMode = Schema.RequiredMode.REQUIRED, example = "1")
|
||||
// 对应 PromotionTypeEnum 枚举
|
||||
private Integer type;
|
||||
private Integer type; // 对应 PromotionTypeEnum 枚举
|
||||
|
||||
@Schema(description = "活动名称", requiredMode = Schema.RequiredMode.REQUIRED, example = "618 大促")
|
||||
private String name;
|
||||
|
||||
@Schema(description = "spu 编号", requiredMode = Schema.RequiredMode.REQUIRED, example = "618")
|
||||
private Long spuId;
|
||||
|
||||
@Schema(description = "活动开始时间", requiredMode = Schema.RequiredMode.REQUIRED)
|
||||
private LocalDateTime startTime;
|
||||
|
||||
|
@@ -8,8 +8,10 @@ import cn.iocoder.yudao.module.promotion.controller.admin.bargain.vo.activity.Ba
|
||||
import cn.iocoder.yudao.module.promotion.dal.dataobject.bargain.BargainActivityDO;
|
||||
import com.baomidou.mybatisplus.core.conditions.update.LambdaUpdateWrapper;
|
||||
import org.apache.ibatis.annotations.Mapper;
|
||||
import org.apache.ibatis.annotations.Select;
|
||||
|
||||
import java.time.LocalDateTime;
|
||||
import java.util.Collection;
|
||||
import java.util.List;
|
||||
|
||||
/**
|
||||
@@ -83,12 +85,23 @@ public interface BargainActivityMapper extends BaseMapperX<BargainActivityDO> {
|
||||
.last("LIMIT " + count));
|
||||
}
|
||||
|
||||
// TODO @puhui999:需要开启状态;另外,是不是可以 limit1,不用 throwEx = false 处理呀?另外,时间要满足噢
|
||||
default BargainActivityDO selectOne(Long spuId) {
|
||||
return selectOne(new LambdaQueryWrapperX<BargainActivityDO>()
|
||||
.eq(BargainActivityDO::getSpuId, spuId)
|
||||
.orderByDesc(BargainActivityDO::getCreateTime)
|
||||
, false);
|
||||
}
|
||||
/**
|
||||
* 获取指定 spu 编号最近参加的活动,每个 spuId 只返回一条记录
|
||||
*
|
||||
* @param spuIds spu 编号
|
||||
* @param status 状态
|
||||
* @return 砍价活动列表
|
||||
*/
|
||||
@Select("SELECT p1.* " +
|
||||
"FROM promotion_bargain_activity p1 " +
|
||||
"INNER JOIN ( " +
|
||||
" SELECT spu_id, MAX(DISTINCT(create_time)) AS max_create_time " +
|
||||
" FROM promotion_bargain_activity " +
|
||||
" WHERE spu_id IN #{spuIds} " +
|
||||
" GROUP BY spu_id " +
|
||||
") p2 " +
|
||||
"ON p1.spu_id = p2.spu_id AND p1.create_time = p2.max_create_time AND p1.status = #{status} " +
|
||||
"ORDER BY p1.create_time DESC;")
|
||||
List<BargainActivityDO> selectListBySpuIds(Collection<Long> spuIds, Integer status);
|
||||
|
||||
}
|
||||
|
@@ -7,7 +7,10 @@ import cn.iocoder.yudao.framework.mybatis.core.query.LambdaQueryWrapperX;
|
||||
import cn.iocoder.yudao.module.promotion.controller.admin.combination.vo.activity.CombinationActivityPageReqVO;
|
||||
import cn.iocoder.yudao.module.promotion.dal.dataobject.combination.CombinationActivityDO;
|
||||
import org.apache.ibatis.annotations.Mapper;
|
||||
import org.apache.ibatis.annotations.Param;
|
||||
import org.apache.ibatis.annotations.Select;
|
||||
|
||||
import java.util.Collection;
|
||||
import java.util.List;
|
||||
|
||||
/**
|
||||
@@ -40,12 +43,23 @@ public interface CombinationActivityMapper extends BaseMapperX<CombinationActivi
|
||||
.last("LIMIT " + count));
|
||||
}
|
||||
|
||||
// TODO @puhui999:需要开启状态;另外,是不是可以 limit1,不用 throwEx = false 处理呀?另外,时间要满足噢
|
||||
default CombinationActivityDO selectOne(Long spuId) {
|
||||
return selectOne(new LambdaQueryWrapperX<CombinationActivityDO>()
|
||||
.eq(CombinationActivityDO::getSpuId, spuId)
|
||||
.orderByDesc(CombinationActivityDO::getCreateTime)
|
||||
, false);
|
||||
}
|
||||
/**
|
||||
* 获取指定 spu 编号最近参加的活动,每个 spuId 只返回一条记录
|
||||
*
|
||||
* @param spuIds spu 编号
|
||||
* @param status 状态
|
||||
* @return 拼团活动列表
|
||||
*/
|
||||
@Select("SELECT p1.* " +
|
||||
"FROM promotion_combination_activity p1 " +
|
||||
"INNER JOIN ( " +
|
||||
" SELECT spu_id, MAX(DISTINCT(create_time)) AS max_create_time " +
|
||||
" FROM promotion_combination_activity " +
|
||||
" WHERE spu_id IN #{spuIds} " +
|
||||
" GROUP BY spu_id " +
|
||||
") p2 " +
|
||||
"ON p1.spu_id = p2.spu_id AND p1.create_time = p2.max_create_time AND p1.status = #{status} " +
|
||||
"ORDER BY p1.create_time DESC;")
|
||||
List<CombinationActivityDO> selectListBySpuIds(@Param("spuIds") Collection<Long> spuIds, @Param("status") Integer status);
|
||||
|
||||
}
|
||||
|
@@ -9,7 +9,9 @@ import cn.iocoder.yudao.module.promotion.controller.app.seckill.vo.activity.AppS
|
||||
import cn.iocoder.yudao.module.promotion.dal.dataobject.seckill.SeckillActivityDO;
|
||||
import com.baomidou.mybatisplus.core.conditions.update.LambdaUpdateWrapper;
|
||||
import org.apache.ibatis.annotations.Mapper;
|
||||
import org.apache.ibatis.annotations.Select;
|
||||
|
||||
import java.util.Collection;
|
||||
import java.util.List;
|
||||
|
||||
/**
|
||||
@@ -56,12 +58,23 @@ public interface SeckillActivityMapper extends BaseMapperX<SeckillActivityDO> {
|
||||
.apply(ObjectUtil.isNotNull(pageReqVO.getConfigId()), "FIND_IN_SET(" + pageReqVO.getConfigId() + ",config_ids) > 0"));
|
||||
}
|
||||
|
||||
// TODO @puhui999:需要开启状态;另外,是不是可以 limit1,不用 throwEx = false 处理呀?另外,时间要满足噢;
|
||||
default SeckillActivityDO selectOne(Long spuId) {
|
||||
return selectOne(new LambdaQueryWrapperX<SeckillActivityDO>()
|
||||
.eq(SeckillActivityDO::getSpuId, spuId)
|
||||
.orderByDesc(SeckillActivityDO::getCreateTime)
|
||||
, false);
|
||||
}
|
||||
/**
|
||||
* 获取指定 spu 编号最近参加的活动,每个 spuId 只返回一条记录
|
||||
*
|
||||
* @param spuIds spu 编号
|
||||
* @param status 状态
|
||||
* @return 秒杀活动列表
|
||||
*/
|
||||
@Select("SELECT p1.* " +
|
||||
"FROM promotion_seckill_activity p1 " +
|
||||
"INNER JOIN ( " +
|
||||
" SELECT spu_id, MAX(DISTINCT(create_time)) AS max_create_time " +
|
||||
" FROM promotion_seckill_activity " +
|
||||
" WHERE spu_id IN #{spuIds} " +
|
||||
" GROUP BY spu_id " +
|
||||
") p2 " +
|
||||
"ON p1.spu_id = p2.spu_id AND p1.create_time = p2.max_create_time AND p1.status = #{status} " +
|
||||
"ORDER BY p1.create_time DESC;")
|
||||
List<SeckillActivityDO> selectListBySpuIds(Collection<Long> spuIds, Integer status);
|
||||
|
||||
}
|
||||
|
@@ -8,6 +8,7 @@ import cn.iocoder.yudao.module.promotion.controller.admin.bargain.vo.activity.Ba
|
||||
import cn.iocoder.yudao.module.promotion.dal.dataobject.bargain.BargainActivityDO;
|
||||
|
||||
import javax.validation.Valid;
|
||||
import java.util.Collection;
|
||||
import java.util.List;
|
||||
import java.util.Set;
|
||||
|
||||
@@ -99,11 +100,12 @@ public interface BargainActivityService {
|
||||
List<BargainActivityDO> getBargainActivityListByCount(Integer count);
|
||||
|
||||
/**
|
||||
* 获取指定 spu 编号的活动
|
||||
* 获取指定 spu 编号最近参加的活动,每个 spuId 只返回一条记录
|
||||
*
|
||||
* @param spuId spu 编号
|
||||
* @return 砍价活动
|
||||
* @param spuIds spu 编号
|
||||
* @param status 状态
|
||||
* @return 砍价活动列表
|
||||
*/
|
||||
BargainActivityDO getBargainActivityBySpuId(Long spuId);
|
||||
List<BargainActivityDO> getBargainActivityBySpuIdsAndStatus(Collection<Long> spuIds, Integer status);
|
||||
|
||||
}
|
||||
|
@@ -20,6 +20,7 @@ import org.springframework.validation.annotation.Validated;
|
||||
|
||||
import javax.annotation.Resource;
|
||||
import java.time.LocalDateTime;
|
||||
import java.util.Collection;
|
||||
import java.util.List;
|
||||
import java.util.Set;
|
||||
|
||||
@@ -176,8 +177,8 @@ public class BargainActivityServiceImpl implements BargainActivityService {
|
||||
}
|
||||
|
||||
@Override
|
||||
public BargainActivityDO getBargainActivityBySpuId(Long spuId) {
|
||||
return bargainActivityMapper.selectOne(spuId);
|
||||
public List<BargainActivityDO> getBargainActivityBySpuIdsAndStatus(Collection<Long> spuIds, Integer status) {
|
||||
return bargainActivityMapper.selectListBySpuIds(spuIds, status);
|
||||
}
|
||||
|
||||
}
|
||||
|
@@ -118,11 +118,12 @@ public interface CombinationActivityService {
|
||||
CombinationProductDO selectByActivityIdAndSkuId(Long activityId, Long skuId);
|
||||
|
||||
/**
|
||||
* 获取指定 spu 编号的活动
|
||||
* 获取指定 spu 编号最近参加的活动,每个 spuId 只返回一条记录
|
||||
*
|
||||
* @param spuId spu 编号
|
||||
* @return 拼团活动
|
||||
* @param spuIds spu 编号
|
||||
* @param status 状态
|
||||
* @return 拼团活动列表
|
||||
*/
|
||||
CombinationActivityDO getCombinationActivityBySpuId(Long spuId);
|
||||
List<CombinationActivityDO> getCombinationActivityBySpuIdsAndStatus(Collection<Long> spuIds, Integer status);
|
||||
|
||||
}
|
||||
|
@@ -227,8 +227,8 @@ public class CombinationActivityServiceImpl implements CombinationActivityServic
|
||||
}
|
||||
|
||||
@Override
|
||||
public CombinationActivityDO getCombinationActivityBySpuId(Long spuId) {
|
||||
return combinationActivityMapper.selectOne(spuId);
|
||||
public List<CombinationActivityDO> getCombinationActivityBySpuIdsAndStatus(Collection<Long> spuIds, Integer status) {
|
||||
return combinationActivityMapper.selectListBySpuIds(spuIds, status);
|
||||
}
|
||||
|
||||
}
|
||||
|
@@ -120,11 +120,12 @@ public interface SeckillActivityService {
|
||||
SeckillValidateJoinRespDTO validateJoinSeckill(Long activityId, Long skuId, Integer count);
|
||||
|
||||
/**
|
||||
* 获取指定 spu 编号的活动
|
||||
* 获取指定 spu 编号最近参加的活动,每个 spuId 只返回一条记录
|
||||
*
|
||||
* @param spuId spu 编号
|
||||
* @return 秒杀活动
|
||||
* @param spuIds spu 编号
|
||||
* @param status 状态
|
||||
* @return 秒杀活动列表
|
||||
*/
|
||||
SeckillActivityDO getSeckillActivityBySpuId(Long spuId);
|
||||
List<SeckillActivityDO> getSeckillActivityBySpuIdsAndStatus(Collection<Long> spuIds, Integer status);
|
||||
|
||||
}
|
||||
|
@@ -311,8 +311,8 @@ public class SeckillActivityServiceImpl implements SeckillActivityService {
|
||||
}
|
||||
|
||||
@Override
|
||||
public SeckillActivityDO getSeckillActivityBySpuId(Long spuId) {
|
||||
return seckillActivityMapper.selectOne(spuId);
|
||||
public List<SeckillActivityDO> getSeckillActivityBySpuIdsAndStatus(Collection<Long> spuIds, Integer status) {
|
||||
return seckillActivityMapper.selectListBySpuIds(spuIds, status);
|
||||
}
|
||||
|
||||
}
|
||||
|
Reference in New Issue
Block a user