完善 PostServiceImpl 单元测试

2025-11-01 02:38:43 +08:00 · 2023-02-01 00:42:38 +08:00
parent 1011de3278
commit bef06ef940
13 changed files with 217 additions and 156 deletions
--- a/yudao-module-system/yudao-module-system-biz/src/test/java/cn/iocoder/yudao/module/system/service/dept/DeptServiceImplTest.java
+++ b/yudao-module-system/yudao-module-system-biz/src/test/java/cn/iocoder/yudao/module/system/service/dept/DeptServiceImplTest.java
@@ -337,7 +337,7 @@ public class DeptServiceImplTest extends BaseDbUnitTest {
        List<Long> ids = singletonList(deptDO.getId());

        // 调用, 并断言异常
-        assertServiceException(() -> deptService.validateDeptList(ids), DEPT_NOT_ENABLE);
+        assertServiceException(() -> deptService.validateDeptList(ids), DEPT_NOT_ENABLE, deptDO.getName());
    }

    @SafeVarargs
--- a/yudao-module-system/yudao-module-system-biz/src/test/java/cn/iocoder/yudao/module/system/service/dept/PostServiceImplTest.java
+++ b/yudao-module-system/yudao-module-system-biz/src/test/java/cn/iocoder/yudao/module/system/service/dept/PostServiceImplTest.java
@@ -1,41 +1,136 @@
 package cn.iocoder.yudao.module.system.service.dept;

-import cn.iocoder.yudao.module.system.dal.dataobject.dept.PostDO;
 import cn.iocoder.yudao.framework.common.enums.CommonStatusEnum;
 import cn.iocoder.yudao.framework.common.pojo.PageResult;
 import cn.iocoder.yudao.framework.common.util.collection.ArrayUtils;
-import cn.iocoder.yudao.framework.common.util.object.ObjectUtils;
+import cn.iocoder.yudao.framework.test.core.ut.BaseDbUnitTest;
 import cn.iocoder.yudao.module.system.controller.admin.dept.vo.post.PostCreateReqVO;
 import cn.iocoder.yudao.module.system.controller.admin.dept.vo.post.PostExportReqVO;
 import cn.iocoder.yudao.module.system.controller.admin.dept.vo.post.PostPageReqVO;
 import cn.iocoder.yudao.module.system.controller.admin.dept.vo.post.PostUpdateReqVO;
+import cn.iocoder.yudao.module.system.dal.dataobject.dept.PostDO;
 import cn.iocoder.yudao.module.system.dal.mysql.dept.PostMapper;
-import cn.iocoder.yudao.framework.test.core.ut.BaseDbUnitTest;
 import org.junit.jupiter.api.Test;
 import org.springframework.context.annotation.Import;

 import javax.annotation.Resource;
+import java.util.Arrays;
 import java.util.List;
 import java.util.function.Consumer;

 import static cn.hutool.core.util.RandomUtil.randomEle;
+import static cn.iocoder.yudao.framework.common.util.object.ObjectUtils.cloneIgnoreId;
 import static cn.iocoder.yudao.framework.test.core.util.AssertUtils.assertPojoEquals;
 import static cn.iocoder.yudao.framework.test.core.util.AssertUtils.assertServiceException;
-import static cn.iocoder.yudao.framework.test.core.util.RandomUtils.randomLongId;
-import static cn.iocoder.yudao.framework.test.core.util.RandomUtils.randomPojo;
+import static cn.iocoder.yudao.framework.test.core.util.RandomUtils.*;
 import static cn.iocoder.yudao.module.system.enums.ErrorCodeConstants.*;
+import static java.util.Collections.singletonList;
 import static org.junit.jupiter.api.Assertions.*;

+/**
+ * {@link PostServiceImpl} 的单元测试类
+ *
+ * @author niudehua
+ */
@Import(PostServiceImpl.class)
-public class PostServiceTest extends BaseDbUnitTest {
+public class PostServiceImplTest extends BaseDbUnitTest {

    @Resource
    private PostServiceImpl postService;
+
    @Resource
    private PostMapper postMapper;

    @Test
-    void testPagePosts() {
+    public void testCreatePost_success() {
+        // 准备参数
+        PostCreateReqVO reqVO = randomPojo(PostCreateReqVO.class,
+                o -> o.setStatus(randomEle(CommonStatusEnum.values()).getStatus()));
+        // 调用
+        Long postId = postService.createPost(reqVO);
+
+        // 断言
+        assertNotNull(postId);
+        // 校验记录的属性是否正确
+        PostDO post = postMapper.selectById(postId);
+        assertPojoEquals(reqVO, post);
+    }
+
+    @Test
+    public void testUpdatePost_success() {
+        // mock 数据
+        PostDO postDO = randomPostDO();
+        postMapper.insert(postDO);// @Sql: 先插入出一条存在的数据
+        // 准备参数
+        PostUpdateReqVO reqVO = randomPojo(PostUpdateReqVO.class, o -> {
+            // 设置更新的 ID
+            o.setId(postDO.getId());
+            o.setStatus(randomEle(CommonStatusEnum.values()).getStatus());
+        });
+
+        // 调用
+        postService.updatePost(reqVO);
+        // 校验是否更新正确
+        PostDO post = postMapper.selectById(reqVO.getId());
+        assertPojoEquals(reqVO, post);
+    }
+
+    @Test
+    public void testDeletePost_success() {
+        // mock 数据
+        PostDO postDO = randomPostDO();
+        postMapper.insert(postDO);
+        // 准备参数
+        Long id = postDO.getId();
+
+        // 调用
+        postService.deletePost(id);
+        assertNull(postMapper.selectById(id));
+    }
+
+    @Test
+    public void testValidatePost_notFoundForDelete() {
+        // 准备参数
+        Long id = randomLongId();
+
+        // 调用, 并断言异常
+        assertServiceException(() -> postService.deletePost(id), POST_NOT_FOUND);
+    }
+
+    @Test
+    public void testValidatePost_nameDuplicateForCreate() {
+        // mock 数据
+        PostDO postDO = randomPostDO();
+        postMapper.insert(postDO);// @Sql: 先插入出一条存在的数据
+        // 准备参数
+        PostCreateReqVO reqVO = randomPojo(PostCreateReqVO.class,
+            // 模拟 name 重复
+            o -> o.setName(postDO.getName()));
+        assertServiceException(() -> postService.createPost(reqVO), POST_NAME_DUPLICATE);
+    }
+
+    @Test
+    public void testValidatePost_codeDuplicateForUpdate() {
+        // mock 数据
+        PostDO postDO = randomPostDO();
+        postMapper.insert(postDO);
+        // mock 数据：稍后模拟重复它的 code
+        PostDO codePostDO = randomPostDO();
+        postMapper.insert(codePostDO);
+        // 准备参数
+        PostUpdateReqVO reqVO = randomPojo(PostUpdateReqVO.class, o -> {
+            // 设置更新的 ID
+            o.setId(postDO.getId());
+            // 模拟 code 重复
+            o.setCode(codePostDO.getCode());
+        });
+
+        // 调用, 并断言异常
+        assertServiceException(() -> postService.updatePost(reqVO), POST_CODE_DUPLICATE);
+    }
+
+    @Test
+    public void testGetPostPage() {
        // mock 数据
        PostDO postDO = randomPojo(PostDO.class, o -> {
            o.setName("码仔");
@@ -43,10 +138,9 @@ public class PostServiceTest extends BaseDbUnitTest {
        });
        postMapper.insert(postDO);
        // 测试 name 不匹配
-        postMapper.insert(ObjectUtils.cloneIgnoreId(postDO, o -> o.setName("程序员")));
+        postMapper.insert(cloneIgnoreId(postDO, o -> o.setName("程序员")));
        // 测试 status 不匹配
-        postMapper.insert(ObjectUtils.cloneIgnoreId(postDO, o -> o.setStatus(CommonStatusEnum.DISABLE.getStatus())));
-
+        postMapper.insert(cloneIgnoreId(postDO, o -> o.setStatus(CommonStatusEnum.DISABLE.getStatus())));
        // 准备参数
        PostPageReqVO reqVO = new PostPageReqVO();
        reqVO.setName("码");
@@ -54,7 +148,6 @@ public class PostServiceTest extends BaseDbUnitTest {

        // 调用
        PageResult<PostDO> pageResult = postService.getPostPage(reqVO);
-
        // 断言
        assertEquals(1, pageResult.getTotal());
        assertEquals(1, pageResult.getList().size());
@@ -62,7 +155,7 @@ public class PostServiceTest extends BaseDbUnitTest {
    }

    @Test
-    void testListPosts() {
+    public void testGetPostList_export() {
        // mock 数据
        PostDO postDO = randomPojo(PostDO.class, o -> {
            o.setName("码仔");
@@ -70,23 +163,41 @@ public class PostServiceTest extends BaseDbUnitTest {
        });
        postMapper.insert(postDO);
        // 测试 name 不匹配
-        postMapper.insert(ObjectUtils.cloneIgnoreId(postDO, o -> o.setName("程序员")));
+        postMapper.insert(cloneIgnoreId(postDO, o -> o.setName("程序员")));
        // 测试 status 不匹配
-        postMapper.insert(ObjectUtils.cloneIgnoreId(postDO, o -> o.setStatus(CommonStatusEnum.DISABLE.getStatus())));
+        postMapper.insert(cloneIgnoreId(postDO, o -> o.setStatus(CommonStatusEnum.DISABLE.getStatus())));
        // 准备参数
        PostExportReqVO reqVO = new PostExportReqVO();
        reqVO.setName("码");
        reqVO.setStatus(CommonStatusEnum.ENABLE.getStatus());

        // 调用
-        List<PostDO> list = postService.getPosts(reqVO);
+        List<PostDO> list = postService.getPostList(reqVO);
        // 断言
        assertEquals(1, list.size());
        assertPojoEquals(postDO, list.get(0));
    }

    @Test
-    void testGetPost() {
+    public void testGetPostList() {
+        // mock 数据
+        PostDO postDO01 = randomPojo(PostDO.class, o -> o.setStatus(CommonStatusEnum.ENABLE.getStatus()));
+        postMapper.insert(postDO01);
+        // 测试 status 不匹配
+        PostDO postDO02 = randomPojo(PostDO.class, o -> o.setStatus(CommonStatusEnum.DISABLE.getStatus()));
+        postMapper.insert(postDO02);
+        // 准备参数
+        List<Long> ids = Arrays.asList(postDO01.getId(), postDO02.getId());
+
+        // 调用
+        List<PostDO> list = postService.getPostList(ids, singletonList(CommonStatusEnum.ENABLE.getStatus()));
+        // 断言
+        assertEquals(1, list.size());
+        assertPojoEquals(postDO01, list.get(0));
+    }
+
+    @Test
+    public void testGetPost() {
        // mock 数据
        PostDO dbPostDO = randomPostDO();
        postMapper.insert(dbPostDO);
@@ -100,94 +211,43 @@ public class PostServiceTest extends BaseDbUnitTest {
    }

    @Test
-    void testCreatePost_success() {
-        // 准备参数
-        PostCreateReqVO reqVO = randomPojo(PostCreateReqVO.class,
-            o -> o.setStatus(randomEle(CommonStatusEnum.values()).getStatus()));
-        // 调用
-        Long postId = postService.createPost(reqVO);
-        // 断言
-        assertNotNull(postId);
-        // 校验记录的属性是否正确
-        PostDO post = postMapper.selectById(postId);
-        assertPojoEquals(reqVO, post);
-    }
-
-    @Test
-    void testUpdatePost_success() {
+    public void testValidatePostList_success() {
        // mock 数据
-        PostDO postDO = randomPostDO();
-        postMapper.insert(postDO);// @Sql: 先插入出一条存在的数据
-        // 准备参数
-        PostUpdateReqVO reqVO = randomPojo(PostUpdateReqVO.class,
-            o -> {
-                // 设置更新的 ID
-                o.setId(postDO.getId());
-                o.setStatus(randomEle(CommonStatusEnum.values()).getStatus());
-            });
-        // 调用
-        postService.updatePost(reqVO);
-        // 校验是否更新正确
-        PostDO post = postMapper.selectById(reqVO.getId());// 获取最新的
-        assertPojoEquals(reqVO, post);
-    }
-
-    @Test
-    void testDeletePost_success() {
-        // mock 数据
-        PostDO postDO = randomPostDO();
+        PostDO postDO = randomPostDO().setStatus(CommonStatusEnum.ENABLE.getStatus());
        postMapper.insert(postDO);
        // 准备参数
-        Long id = postDO.getId();
-        // 调用
-        postService.deletePost(id);
-        assertNull(postMapper.selectById(id));
+        List<Long> ids = singletonList(postDO.getId());
+
+        // 调用，无需断言
+        postService.validatePostList(ids);
    }

    @Test
-    void testCheckPost_notFoundForDelete() {
+    public void testValidatePostList_notFound() {
        // 准备参数
-        Long id = randomLongId();
+        List<Long> ids = singletonList(randomLongId());
+
        // 调用, 并断言异常
-        assertServiceException(() -> postService.deletePost(id), POST_NOT_FOUND);
+        assertServiceException(() -> postService.validatePostList(ids), POST_NOT_FOUND);
    }

    @Test
-    void testCheckPost_nameDuplicateForCreate() {
+    public void testValidatePostList_notEnable() {
        // mock 数据
-        PostDO postDO = randomPostDO();
-        postMapper.insert(postDO);// @Sql: 先插入出一条存在的数据
-        // 准备参数
-        PostCreateReqVO reqVO = randomPojo(PostCreateReqVO.class,
-            // 模拟 name 重复
-            o -> o.setName(postDO.getName()));
-        assertServiceException(() -> postService.createPost(reqVO), POST_NAME_DUPLICATE);
-    }
-
-    @Test
-    void testCheckPost_codeDuplicateForUpdate() {
-        // mock 数据
-        PostDO postDO = randomPostDO();
+        PostDO postDO = randomPostDO().setStatus(CommonStatusEnum.DISABLE.getStatus());
        postMapper.insert(postDO);
-        // mock 数据 稍后模拟重复它的 code
-        PostDO codePostDO = randomPostDO();
-        postMapper.insert(codePostDO);
        // 准备参数
-        PostUpdateReqVO reqVO = randomPojo(PostUpdateReqVO.class,
-            o -> {
-                // 设置更新的 ID
-                o.setId(postDO.getId());
-                // 模拟 code 重复
-                o.setCode(codePostDO.getCode());
-            });
+        List<Long> ids = singletonList(postDO.getId());
+
        // 调用, 并断言异常
-        assertServiceException(() -> postService.updatePost(reqVO), POST_CODE_DUPLICATE);
+        assertServiceException(() -> postService.validatePostList(ids), POST_NOT_ENABLE,
+                postDO.getName());
    }

    @SafeVarargs
    private static PostDO randomPostDO(Consumer<PostDO>... consumers) {
        Consumer<PostDO> consumer = (o) -> {
-            o.setStatus(randomEle(CommonStatusEnum.values()).getStatus()); // 保证 status 的范围
+            o.setStatus(randomCommonStatus()); // 保证 status 的范围
        };
        return randomPojo(PostDO.class, ArrayUtils.append(consumer, consumers));
    }
--- a/yudao-module-system/yudao-module-system-biz/src/test/java/cn/iocoder/yudao/module/system/service/user/AdminUserServiceImplTest.java
+++ b/yudao-module-system/yudao-module-system-biz/src/test/java/cn/iocoder/yudao/module/system/service/user/AdminUserServiceImplTest.java
@@ -102,7 +102,7 @@ public class AdminUserServiceImplTest extends BaseDbUnitTest {
                    o.setId(postId);
                    o.setStatus(CommonStatusEnum.ENABLE.getStatus());
                }));
-        when(postService.getPosts(eq(reqVO.getPostIds()), isNull())).thenReturn(posts);
+        when(postService.getPostList(eq(reqVO.getPostIds()), isNull())).thenReturn(posts);
        // mock passwordEncoder 的方法
        when(passwordEncoder.encode(eq(reqVO.getPassword()))).thenReturn("yudaoyuanma");

@@ -160,7 +160,7 @@ public class AdminUserServiceImplTest extends BaseDbUnitTest {
                    o.setId(postId);
                    o.setStatus(CommonStatusEnum.ENABLE.getStatus());
                }));
-        when(postService.getPosts(eq(reqVO.getPostIds()), isNull())).thenReturn(posts);
+        when(postService.getPostList(eq(reqVO.getPostIds()), isNull())).thenReturn(posts);

        // 调用
        userService.updateUser(reqVO);