mirror of
				https://gitee.com/hhyykk/ipms-sjy.git
				synced 2025-10-31 18:28:43 +08:00 
			
		
		
		
	| @@ -33,7 +33,6 @@ public class CrmStatisticsPerformanceReqVO { | ||||
|     @Schema(description = "负责人用户 id 集合", requiredMode = Schema.RequiredMode.NOT_REQUIRED, example = "2") | ||||
|     private List<Long> userIds; | ||||
|  | ||||
|     // TODO @scholar:应该传递的是 int year;年份 | ||||
|     @Schema(description = "时间范围", requiredMode = Schema.RequiredMode.REQUIRED) | ||||
|     @DateTimeFormat(pattern = FORMAT_YEAR_MONTH_DAY_HOUR_MINUTE_SECOND) | ||||
|     @NotEmpty(message = "时间范围不能为空") | ||||
|   | ||||
| @@ -1,8 +1,6 @@ | ||||
| package cn.iocoder.yudao.module.crm.service.statistics; | ||||
|  | ||||
| import cn.hutool.core.collection.CollUtil; | ||||
| import cn.hutool.core.collection.ListUtil; | ||||
| import cn.hutool.core.date.LocalDateTimeUtil; | ||||
| import cn.hutool.core.util.ObjUtil; | ||||
| import cn.iocoder.yudao.module.crm.controller.admin.statistics.vo.performance.CrmStatisticsPerformanceReqVO; | ||||
| import cn.iocoder.yudao.module.crm.controller.admin.statistics.vo.performance.CrmStatisticsPerformanceRespVO; | ||||
| @@ -11,16 +9,20 @@ import cn.iocoder.yudao.module.system.api.dept.DeptApi; | ||||
| import cn.iocoder.yudao.module.system.api.dept.dto.DeptRespDTO; | ||||
| import cn.iocoder.yudao.module.system.api.user.AdminUserApi; | ||||
| import cn.iocoder.yudao.module.system.api.user.dto.AdminUserRespDTO; | ||||
| import jakarta.annotation.Resource; | ||||
| import org.springframework.stereotype.Service; | ||||
| import org.springframework.validation.annotation.Validated; | ||||
|  | ||||
| import jakarta.annotation.Resource; | ||||
|  | ||||
| import java.math.BigDecimal; | ||||
| import java.util.*; | ||||
| import java.time.LocalDateTime; | ||||
| import java.util.ArrayList; | ||||
| import java.util.Collections; | ||||
| import java.util.List; | ||||
| import java.util.Map; | ||||
| import java.util.function.Function; | ||||
|  | ||||
| import static cn.iocoder.yudao.framework.common.util.collection.CollectionUtils.convertList; | ||||
| import static cn.iocoder.yudao.framework.common.util.collection.CollectionUtils.convertMap; | ||||
|  | ||||
| /** | ||||
|  * CRM 员工业绩分析 Service 实现类 | ||||
| @@ -41,10 +43,6 @@ public class CrmStatisticsPerformanceServiceImpl implements CrmStatisticsPerform | ||||
|  | ||||
|     @Override | ||||
|     public List<CrmStatisticsPerformanceRespVO> getContractCountPerformance(CrmStatisticsPerformanceReqVO performanceReqVO) { | ||||
|         // TODO @scholar:可以把下面这个注释,你理解后,重新整理下,写到 getPerformance 里; | ||||
|         // 比如说,2024 年的合同数据,是不是 2022-12 到 2024-12-31,每个月的统计呢? | ||||
|         // 理解之后,我们可以数据 group by 年-月,20222-12 到 2024-12-31 的,然后内存在聚合出 CrmStatisticsPerformanceRespVO 这样 | ||||
|         // 这样,我们就可以减少数据库的计算量,提升性能;同时 SQL 也会很简单,开发者理解起来也简单哈; | ||||
|         return getPerformance(performanceReqVO, performanceMapper::selectContractCountPerformance); | ||||
|     } | ||||
|  | ||||
| @@ -58,99 +56,45 @@ public class CrmStatisticsPerformanceServiceImpl implements CrmStatisticsPerform | ||||
|         return getPerformance(performanceReqVO, performanceMapper::selectReceivablePricePerformance); | ||||
|     } | ||||
|  | ||||
|     // TODO @scholar:代码注释,应该有 3 个变量哈; | ||||
|     /** | ||||
|      * 获得员工业绩数据 | ||||
|      * | ||||
|      * 1. 获得今年 + 去年的数据 | ||||
|      * 2. 遍历今年的月份,逐个拼接去年的月份数据 | ||||
|      * | ||||
|      * @param performanceReqVO  参数 | ||||
|      * @param performanceFunction 员工业绩统计方法 | ||||
|      * @return 员工业绩数据 | ||||
|      */ | ||||
|     // TODO @scholar:下面一行的变量,超过一行了,阅读不美观;可以考虑每一行一个变量; | ||||
|     private List<CrmStatisticsPerformanceRespVO> getPerformance(CrmStatisticsPerformanceReqVO performanceReqVO, Function<CrmStatisticsPerformanceReqVO, | ||||
|             List<CrmStatisticsPerformanceRespVO>> performanceFunction) { | ||||
|  | ||||
|         // TODO @scholar:没使用到的变量,建议删除; | ||||
|         List<CrmStatisticsPerformanceRespVO> performanceRespVOList; | ||||
|     private List<CrmStatisticsPerformanceRespVO> getPerformance(CrmStatisticsPerformanceReqVO performanceReqVO, | ||||
|                                                                 Function<CrmStatisticsPerformanceReqVO, List<CrmStatisticsPerformanceRespVO>> performanceFunction) { | ||||
|  | ||||
|         // 1. 获得用户编号数组 | ||||
|         final List<Long> userIds = getUserIds(performanceReqVO); | ||||
|         List<Long> userIds = getUserIds(performanceReqVO); | ||||
|         if (CollUtil.isEmpty(userIds)) { | ||||
|             return Collections.emptyList(); | ||||
|         } | ||||
|         performanceReqVO.setUserIds(userIds); | ||||
|         // TODO @scholar:1. 和 2. 之间,可以考虑换一行;保证每一块逻辑的间隔; | ||||
|  | ||||
|         // 2. 获得业绩数据 | ||||
|         // TODO @scholar:复数变量,建议使用 s 或者 list 结果;这里用 performanceList  好列; | ||||
|         List<CrmStatisticsPerformanceRespVO> performance = performanceFunction.apply(performanceReqVO); | ||||
|         int year = performanceReqVO.getTimes()[0].getYear(); // 获取查询的年份 | ||||
|         performanceReqVO.getTimes()[0] = performanceReqVO.getTimes()[0].minusYears(1); | ||||
|         List<CrmStatisticsPerformanceRespVO> performanceList = performanceFunction.apply(performanceReqVO); | ||||
|         Map<String, BigDecimal> performanceMap = convertMap(performanceList, CrmStatisticsPerformanceRespVO::getTime, | ||||
|                 CrmStatisticsPerformanceRespVO::getCurrentMonthCount); | ||||
|  | ||||
|         // 获取查询的年份 | ||||
|         // TODO @scholar:逻辑可以简化一下; | ||||
|         // TODO 1)把 performance 转换成 map;key 是 time,value 是 count | ||||
|         // TODO 2)当前年,遍历 1-12 月份,去 map 拿到 count;接着月份 -1,去 map 拿 count;再年份 -1,拿 count | ||||
|         String currentYear = LocalDateTimeUtil.format(performanceReqVO.getTimes()[0],"yyyy"); | ||||
|  | ||||
|         // 构造查询当年和前一年,每年12个月的年月组合 | ||||
|         List<String> allMonths = new ArrayList<>(); | ||||
|         for (int year = Integer.parseInt(currentYear)-1; year <= Integer.parseInt(currentYear); year++) { | ||||
|             for (int month = 1; month <= 12; month++) { | ||||
|                 allMonths.add(String.format("%d%02d", year, month)); | ||||
|             } | ||||
|         // 3. 组装数据返回 | ||||
|         List<CrmStatisticsPerformanceRespVO> result = new ArrayList<>(); | ||||
|         for (int month = 1; month <= 12; month++) { | ||||
|             String currentMonth = String.format("%d%02d", year, month); | ||||
|             String lastMonth = month == 1 ? String.format("%d%02d", year - 1, 12) : String.format("%d%02d", year, month - 1); | ||||
|             String lastYear = String.format("%d%02d", year - 1, month); | ||||
|             result.add(new CrmStatisticsPerformanceRespVO().setTime(currentMonth) | ||||
|                     .setCurrentMonthCount(performanceMap.getOrDefault(currentMonth, BigDecimal.ZERO)) | ||||
|                     .setLastMonthCount(performanceMap.getOrDefault(lastMonth, BigDecimal.ZERO)) | ||||
|                     .setLastYearCount(performanceMap.getOrDefault(lastYear, BigDecimal.ZERO))); | ||||
|         } | ||||
|  | ||||
|         List<CrmStatisticsPerformanceRespVO> computedList = new ArrayList<>(); | ||||
|         List<CrmStatisticsPerformanceRespVO> respVOList = new ArrayList<>(); | ||||
|  | ||||
|         // 生成computedList基础数据 | ||||
|         // 构造完整的2*12个月的数据,如果某月数据缺失,需要补上0,一年12个月不能有缺失 | ||||
|         for (String month : allMonths) { | ||||
|             CrmStatisticsPerformanceRespVO foundData = performance.stream() | ||||
|                     .filter(data -> data.getTime().equals(month)) | ||||
|                     .findFirst() | ||||
|                     .orElse(null); | ||||
|  | ||||
|             if (foundData != null) { | ||||
|                 computedList.add(foundData); | ||||
|             } else { | ||||
|                 CrmStatisticsPerformanceRespVO missingData = new CrmStatisticsPerformanceRespVO(); | ||||
|                 missingData.setTime(month); | ||||
|                 missingData.setCurrentMonthCount(BigDecimal.ZERO); | ||||
|                 missingData.setLastMonthCount(BigDecimal.ZERO); | ||||
|                 missingData.setLastYearCount(BigDecimal.ZERO); | ||||
|                 computedList.add(missingData); | ||||
|             } | ||||
|         } | ||||
|         //根据查询年份和前一年的数据,计算查询年份的同比环比数据 | ||||
|         for (CrmStatisticsPerformanceRespVO currentData : computedList) { | ||||
|             String currentMonth = currentData.getTime(); | ||||
|  | ||||
|             // 根据当年和前一年的月销售数据,计算currentYear的完整数据 | ||||
|             if (currentMonth.startsWith(currentYear)) { | ||||
|                 // 计算 LastMonthCount | ||||
|                 int currentIndex = computedList.indexOf(currentData); | ||||
|                 if (currentIndex > 0) { | ||||
|                     CrmStatisticsPerformanceRespVO lastMonthData = computedList.get(currentIndex - 1); | ||||
|                     currentData.setLastMonthCount(lastMonthData.getCurrentMonthCount()); | ||||
|                 } else { | ||||
|                     currentData.setLastMonthCount(BigDecimal.ZERO); // 第一个月的 LastMonthCount 设为0 | ||||
|                 } | ||||
|  | ||||
|                 // 计算 LastYearCount | ||||
|                 String lastYearMonth = String.valueOf(Integer.parseInt(currentMonth) - 100); | ||||
|                 CrmStatisticsPerformanceRespVO lastYearData = computedList.stream() | ||||
|                         .filter(data -> data.getTime().equals(lastYearMonth)) | ||||
|                         .findFirst() | ||||
|                         .orElse(null); | ||||
|  | ||||
|                 if (lastYearData != null) { | ||||
|                     currentData.setLastYearCount(lastYearData.getCurrentMonthCount()); | ||||
|                 } else { | ||||
|                     currentData.setLastYearCount(BigDecimal.ZERO); // 如果去年同月数据不存在,设为0 | ||||
|                 } | ||||
|                 respVOList.add(currentData);//给前端只需要返回查询当年的数据,不需要前一年数据 | ||||
|             } | ||||
|         } | ||||
|         return respVOList; | ||||
|         return result; | ||||
|     } | ||||
|  | ||||
|     /** | ||||
| @@ -162,7 +106,7 @@ public class CrmStatisticsPerformanceServiceImpl implements CrmStatisticsPerform | ||||
|     private List<Long> getUserIds(CrmStatisticsPerformanceReqVO reqVO) { | ||||
|         // 情况一:选中某个用户 | ||||
|         if (ObjUtil.isNotNull(reqVO.getUserId())) { | ||||
|             return ListUtil.of(reqVO.getUserId()); | ||||
|             return List.of(reqVO.getUserId()); | ||||
|         } | ||||
|         // 情况二:选中某个部门 | ||||
|         // 2.1 获得部门列表 | ||||
|   | ||||
| @@ -9,51 +9,47 @@ | ||||
|             COUNT(1) AS currentMonthCount | ||||
|         FROM crm_contract | ||||
|         WHERE deleted = 0 | ||||
|         <!-- TODO @scholar:20 改成静态类引入 --> | ||||
|         AND audit_status = 20 | ||||
|         AND audit_status = ${@cn.iocoder.yudao.module.crm.enums.common.CrmAuditStatusEnum@APPROVE.status} | ||||
|         AND owner_user_id in | ||||
|             <foreach collection="userIds" item="userId" open="(" close=")" separator=","> | ||||
|                 #{userId} | ||||
|             </foreach> | ||||
|         <!-- TODO @scholar:CrmStatisticsPerformanceReqVO 传递 year,然后 java 代码里,转换出 times;这样,order_time 使用范围查询,避免使用函数 --> | ||||
|         AND (DATE_FORMAT(order_date, '%Y') = DATE_FORMAT(#{times[0],javaType=java.time.LocalDateTime}, '%Y') | ||||
|         or DATE_FORMAT(order_date, '%Y') = DATE_FORMAT(#{times[0],javaType=java.time.LocalDateTime}, '%Y') - 1) | ||||
|         AND order_date between #{times[0],javaType=java.time.LocalDateTime} and | ||||
|             #{times[1],javaType=java.time.LocalDateTime} | ||||
|         GROUP BY time | ||||
|     </select> | ||||
|  | ||||
|     <!-- TODO @scholar:参考上面,调整下这个 SQL 的排版、和代码建议哈 --> | ||||
|     <select id="selectContractPricePerformance" | ||||
|             resultType="cn.iocoder.yudao.module.crm.controller.admin.statistics.vo.performance.CrmStatisticsPerformanceRespVO"> | ||||
|         SELECT | ||||
|         DATE_FORMAT(order_date, '%Y%m') AS time, | ||||
|         IFNULL(SUM(total_price), 0) AS currentMonthCount | ||||
|         FROM	crm_contract | ||||
|             DATE_FORMAT(order_date, '%Y%m') AS time, | ||||
|             IFNULL(SUM(total_price), 0) AS currentMonthCount | ||||
|         FROM crm_contract | ||||
|         WHERE deleted = 0 | ||||
|         AND audit_status = 20 | ||||
|         AND audit_status = ${@cn.iocoder.yudao.module.crm.enums.common.CrmAuditStatusEnum@APPROVE.status} | ||||
|         AND owner_user_id in | ||||
|         <foreach collection="userIds" item="userId" open="(" close=")" separator=","> | ||||
|             #{userId} | ||||
|         </foreach> | ||||
|         AND (DATE_FORMAT(order_date, '%Y') = DATE_FORMAT(#{times[0],javaType=java.time.LocalDateTime},'%Y') | ||||
|         or DATE_FORMAT(order_date, '%Y') = DATE_FORMAT(#{times[0],javaType=java.time.LocalDateTime},'%Y')-1) | ||||
|             <foreach collection="userIds" item="userId" open="(" close=")" separator=","> | ||||
|                 #{userId} | ||||
|             </foreach> | ||||
|         AND order_date between #{times[0],javaType=java.time.LocalDateTime} and | ||||
|             #{times[1],javaType=java.time.LocalDateTime} | ||||
|         GROUP BY time | ||||
|     </select> | ||||
|  | ||||
|     <!-- TODO @scholar:参考上面,调整下这个 SQL 的排版、和代码建议哈 --> | ||||
|     <select id="selectReceivablePricePerformance" | ||||
|             resultType="cn.iocoder.yudao.module.crm.controller.admin.statistics.vo.performance.CrmStatisticsPerformanceRespVO"> | ||||
|         SELECT | ||||
|         DATE_FORMAT(return_time, '%Y%m') AS time, | ||||
|         IFNULL(SUM(price), 0) AS currentMonthCount | ||||
|         FROM	crm_receivable | ||||
|             DATE_FORMAT(return_time, '%Y%m') AS time, | ||||
|             IFNULL(SUM(price), 0) AS currentMonthCount | ||||
|         FROM crm_receivable | ||||
|         WHERE deleted = 0 | ||||
|         AND audit_status = 20 | ||||
|         AND audit_status = ${@cn.iocoder.yudao.module.crm.enums.common.CrmAuditStatusEnum@APPROVE.status} | ||||
|         AND owner_user_id in | ||||
|         <foreach collection="userIds" item="userId" open="(" close=")" separator=","> | ||||
|             #{userId} | ||||
|         </foreach> | ||||
|         AND (DATE_FORMAT(return_time, '%Y') = DATE_FORMAT(#{times[0],javaType=java.time.LocalDateTime},'%Y') | ||||
|         or DATE_FORMAT(return_time, '%Y') = DATE_FORMAT(#{times[0],javaType=java.time.LocalDateTime},'%Y')-1) | ||||
|             <foreach collection="userIds" item="userId" open="(" close=")" separator=","> | ||||
|                 #{userId} | ||||
|             </foreach> | ||||
|         AND return_time between #{times[0],javaType=java.time.LocalDateTime} and | ||||
|             #{times[1],javaType=java.time.LocalDateTime} | ||||
|         GROUP BY time | ||||
|     </select> | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 芋道源码
					芋道源码