From 81666e3b6207e96bd4b7e7f35ad7a1ad8289adcb Mon Sep 17 00:00:00 2001 From: YunaiV Date: Tue, 23 Aug 2022 00:38:49 +0800 Subject: [PATCH] =?UTF-8?q?mall=EF=BC=9Acode=20review=20=E5=95=86=E5=93=81?= =?UTF-8?q?=E7=9A=84=E6=B7=BB=E5=8A=A0=E5=92=8C=E4=BF=AE=E6=94=B9=20VO?= =?UTF-8?q?=EF=BC=9B=E5=BE=AE=E8=B0=83=E5=95=86=E5=93=81=E7=9A=84=20SPU/SK?= =?UTF-8?q?U=20=E8=A1=A8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../module/product/service/sku/ProductSkuServiceImpl.java | 6 ++---- .../module/product/service/spu/ProductSpuServiceImpl.java | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuServiceImpl.java b/yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuServiceImpl.java index c8172d157..ea9e97c81 100755 --- a/yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuServiceImpl.java +++ b/yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuServiceImpl.java @@ -2,12 +2,10 @@ package cn.iocoder.yudao.module.product.service.sku; import cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil; import cn.iocoder.yudao.framework.common.pojo.PageResult; -import cn.iocoder.yudao.module.product.controller.admin.property.vo.ProductPropertyCreateReqVO; import cn.iocoder.yudao.module.product.controller.admin.property.vo.ProductPropertyRespVO; -import cn.iocoder.yudao.module.product.controller.admin.propertyvalue.vo.ProductPropertyValueCreateReqVO; import cn.iocoder.yudao.module.product.controller.admin.propertyvalue.vo.ProductPropertyValueRespVO; import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuBaseVO; -import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuCreateReqVO; +import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuCreateOrUpdateReqVO; import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuPageReqVO; import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuUpdateReqVO; import cn.iocoder.yudao.module.product.convert.sku.ProductSkuConvert; @@ -90,7 +88,7 @@ public class ProductSkuServiceImpl implements ProductSkuService { } @Override - public void validateSkus(List list) { + public void validateSkus(List list) { List skuPropertyList = list.stream().flatMap(p -> Optional.of(p.getProperties()).orElse(new ArrayList<>()).stream()).collect(Collectors.toList()); // 校验规格属性以及规格值是否存在 List propertyIds = skuPropertyList.stream().map(ProductSkuBaseVO.Property::getPropertyId).collect(Collectors.toList()); diff --git a/yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/spu/ProductSpuServiceImpl.java b/yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/spu/ProductSpuServiceImpl.java index 1ff0a0340..4fad20bbd 100755 --- a/yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/spu/ProductSpuServiceImpl.java +++ b/yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/spu/ProductSpuServiceImpl.java @@ -56,7 +56,7 @@ public class ProductSpuServiceImpl implements ProductSpuService { // 校验分类 categoryService.validateProductCategory(createReqVO.getCategoryId()); // 校验SKU - List skuCreateReqList = createReqVO.getSkus(); + List skuCreateReqList = createReqVO.getSkus(); if(createReqVO.getSpecType() == 1) { productSkuService.validateSkus(skuCreateReqList); } @@ -78,7 +78,7 @@ public class ProductSpuServiceImpl implements ProductSpuService { // 校验分类 categoryService.validateProductCategory(updateReqVO.getCategoryId()); // 校验SKU - List skuCreateReqList = updateReqVO.getSkus(); + List skuCreateReqList = updateReqVO.getSkus(); if(updateReqVO.getSpecType() == 1) { productSkuService.validateSkus(skuCreateReqList); }