hhyykk/ipms-sjy
1
1
Fork 0
mirror of https://gitee.com/hhyykk/ipms-sjy.git synced 2025-08-17 19:51:53 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

mall: 下单的代码 review

Browse Source
This commit is contained in:
zhijiantianya@gmail.com
2022-09-30 09:53:45 +00:00
parent 952e6aa4a8
commit 67436ea4c6
21 changed files with 48 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/api/sku/ProductSkuApiImpl.java
View File

@@ -16,6 +16,7 @@ import java.util.Collections;
import java.util.List;
/**
* TODO LeeYan9: 类注释;
* @author LeeYan9
* @since 2022-09-06
*/
@@ -28,6 +29,7 @@ public class ProductSkuApiImpl implements ProductSkuApi {
@Override
public List<SkuInfoRespDTO> getSkusByIds(Collection<Long> skuIds) {
// TODO TODO LeeYan9: AllEmpty?
if (CollectionUtils.isAnyEmpty(skuIds)) {
return Collections.emptyList();
}
@@ -38,6 +40,7 @@ public class ProductSkuApiImpl implements ProductSkuApi {
@Override
@Transactional(rollbackFor = Exception.class)
public void decrementStockBatch(SkuDecrementStockBatchReqDTO batchReqDTO) {
// TODO @LeeYan9: 最好 Service 去 for 循环;
productSkuMapper.decrementStockBatch(batchReqDTO.getItems());
}
}

3
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/api/spu/ProductSpuApiImpl.java
View File

@@ -14,6 +14,8 @@ import java.util.Collections;
import java.util.List;
/**
* TODO LeeYan9: 类注释;
*
* @author LeeYan9
* @since 2022-09-06
*/
@@ -26,6 +28,7 @@ public class ProductSpuApiImpl implements ProductSpuApi {
@Override
public List<SpuInfoRespDTO> getSpuList(Collection<Long> spuIds) {
// TODO TODO LeeYan9: AllEmpty?
if (CollectionUtils.isAnyEmpty(spuIds)) {
return Collections.emptyList();
}

1
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/convert/sku/ProductSkuConvert.java
View File

@@ -38,5 +38,4 @@ public interface ProductSkuConvert {
List<SkuInfoRespDTO> convertList03(List<ProductSkuDO> list);
}

3
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/convert/spu/ProductSpuConvert.java
View File

@@ -36,6 +36,5 @@ public interface ProductSpuConvert {
AppSpuPageRespVO convertAppResp(ProductSpuDO list);
List<SpuInfoRespDTO> convertList2(List<ProductSpuDO> list);
}