code review 用户前台的社交登陆

This commit is contained in:
YunaiV
2021-10-28 08:46:51 +08:00
parent 30ad7c43b8
commit 55e5ca4644
11 changed files with 20 additions and 12 deletions

View File

@ -75,6 +75,7 @@ public class SysAuthServiceImpl implements SysAuthService {
@Resource
private SysSocialService socialService;
// TODO @timfruit静态枚举类需要都大写例如说 USER_TYPE_ENUM静态变量放在普通变量前面这个实践不错哈。
private static final UserTypeEnum userTypeEnum = UserTypeEnum.ADMIN;
@Override
@ -214,7 +215,6 @@ public class SysAuthServiceImpl implements SysAuthService {
// 创建 LoginUser 对象
LoginUser loginUser = SysAuthConvert.INSTANCE.convert(user);
// TODO 芋艿:需要改造下,增加各种登录方式
loginUser.setRoleIds(this.getUserRoleIds(loginUser.getId())); // 获取用户角色列表
// 绑定社交用户(更新)