1. 【修复】单元测试报错

2. 【优化】yudao-module-xx-impl 调整成 yudao-module-xx-biz，更加符合定位
2025-08-08 23:31:53 +08:00 · 2022-04-22 00:07:54 +08:00
parent b5821b4bef
commit 09103f310b
895 changed files with 34 additions and 33 deletions
--- a/yudao-module-member/yudao-module-member-biz/src/test/java/cn/iocoder/yudao/module/member/service/auth/MemberAuthServiceTest.java
+++ b/yudao-module-member/yudao-module-member-biz/src/test/java/cn/iocoder/yudao/module/member/service/auth/MemberAuthServiceTest.java
@@ -0,0 +1,122 @@
+package cn.iocoder.yudao.module.member.service.auth;
+
+import cn.iocoder.yudao.framework.common.enums.CommonStatusEnum;
+import cn.iocoder.yudao.framework.common.util.collection.ArrayUtils;
+import cn.iocoder.yudao.framework.redis.config.YudaoRedisAutoConfiguration;
+import cn.iocoder.yudao.framework.test.core.ut.BaseDbAndRedisUnitTest;
+import cn.iocoder.yudao.module.member.controller.app.auth.vo.AppAuthResetPasswordReqVO;
+import cn.iocoder.yudao.module.member.controller.app.auth.vo.AppAuthUpdatePasswordReqVO;
+import cn.iocoder.yudao.module.member.dal.dataobject.user.MemberUserDO;
+import cn.iocoder.yudao.module.member.dal.mysql.user.MemberUserMapper;
+import cn.iocoder.yudao.module.member.service.user.MemberUserService;
+import cn.iocoder.yudao.module.system.api.auth.UserSessionApi;
+import cn.iocoder.yudao.module.system.api.logger.LoginLogApi;
+import cn.iocoder.yudao.module.system.api.sms.SmsCodeApi;
+import cn.iocoder.yudao.module.system.api.social.SocialUserApi;
+import org.junit.jupiter.api.Test;
+import org.springframework.boot.test.mock.mockito.MockBean;
+import org.springframework.context.annotation.Import;
+import org.springframework.security.authentication.AuthenticationManager;
+import org.springframework.security.crypto.password.PasswordEncoder;
+
+import javax.annotation.Resource;
+import java.util.function.Consumer;
+
+import static cn.hutool.core.util.RandomUtil.randomEle;
+import static cn.hutool.core.util.RandomUtil.randomNumbers;
+import static cn.iocoder.yudao.framework.test.core.util.RandomUtils.randomPojo;
+import static cn.iocoder.yudao.framework.test.core.util.RandomUtils.randomString;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.Mockito.when;
+
+// TODO @芋艿：单测的 review，等逻辑都达成一致后
+/**
+ * {@link MemberAuthService} 的单元测试类
+ *
+ * @author 宋天
+ */
+@Import({MemberAuthServiceImpl.class, YudaoRedisAutoConfiguration.class})
+public class MemberAuthServiceTest extends BaseDbAndRedisUnitTest {
+
+    @MockBean
+    private AuthenticationManager authenticationManager;
+    @MockBean
+    private MemberUserService userService;
+    @MockBean
+    private SmsCodeApi smsCodeApi;
+    @MockBean
+    private LoginLogApi loginLogApi;
+    @MockBean
+    private UserSessionApi userSessionApi;
+    @MockBean
+    private SocialUserApi socialUserApi;
+    @MockBean
+    private PasswordEncoder passwordEncoder;
+    @Resource
+    private MemberUserMapper memberUserMapper;
+    @Resource
+    private MemberAuthServiceImpl authService;
+
+    @Test
+    public void testUpdatePassword_success(){
+        // 准备参数
+        MemberUserDO userDO = randomUserDO();
+        memberUserMapper.insert(userDO);
+
+        // 新密码
+        String newPassword = randomString();
+
+        // 请求实体
+        AppAuthUpdatePasswordReqVO reqVO = AppAuthUpdatePasswordReqVO.builder()
+                .oldPassword(userDO.getPassword())
+                .password(newPassword)
+                .build();
+
+        // 测试桩
+        // 这两个相等是为了返回ture这个结果
+        when(passwordEncoder.matches(reqVO.getOldPassword(),reqVO.getOldPassword())).thenReturn(true);
+        when(passwordEncoder.encode(newPassword)).thenReturn(newPassword);
+
+        // 更新用户密码
+        authService.updatePassword(userDO.getId(), reqVO);
+        assertEquals(memberUserMapper.selectById(userDO.getId()).getPassword(),newPassword);
+    }
+
+    @Test
+    public void testResetPassword_success(){
+        // 准备参数
+        MemberUserDO userDO = randomUserDO();
+        memberUserMapper.insert(userDO);
+
+        // 随机密码
+        String password = randomNumbers(11);
+        // 随机验证码
+        String code = randomNumbers(4);
+
+        // mock
+        when(passwordEncoder.encode(password)).thenReturn(password);
+
+        // 更新用户密码
+        AppAuthResetPasswordReqVO reqVO = new AppAuthResetPasswordReqVO();
+        reqVO.setMobile(userDO.getMobile());
+        reqVO.setPassword(password);
+        reqVO.setCode(code);
+
+        authService.resetPassword(reqVO);
+        assertEquals(memberUserMapper.selectById(userDO.getId()).getPassword(),password);
+    }
+
+
+    // ========== 随机对象 ==========
+
+    @SafeVarargs
+    private static MemberUserDO randomUserDO(Consumer<MemberUserDO>... consumers) {
+        Consumer<MemberUserDO> consumer = (o) -> {
+            o.setStatus(randomEle(CommonStatusEnum.values()).getStatus()); // 保证 status 的范围
+            o.setPassword(randomString());
+        };
+        return randomPojo(MemberUserDO.class, ArrayUtils.append(consumer, consumers));
+    }
+
+
+}
--- a/yudao-module-member/yudao-module-member-biz/src/test/java/cn/iocoder/yudao/module/member/service/user/MemberUserServiceImplTest.java
+++ b/yudao-module-member/yudao-module-member-biz/src/test/java/cn/iocoder/yudao/module/member/service/user/MemberUserServiceImplTest.java
@@ -0,0 +1,137 @@
+package cn.iocoder.yudao.module.member.service.user;
+
+import cn.hutool.core.util.RandomUtil;
+import cn.iocoder.yudao.framework.common.enums.CommonStatusEnum;
+import cn.iocoder.yudao.framework.common.util.collection.ArrayUtils;
+import cn.iocoder.yudao.framework.redis.config.YudaoRedisAutoConfiguration;
+import cn.iocoder.yudao.framework.test.core.ut.BaseDbAndRedisUnitTest;
+import cn.iocoder.yudao.module.infra.api.file.FileApi;
+import cn.iocoder.yudao.module.member.controller.app.user.vo.AppUserUpdateMobileReqVO;
+import cn.iocoder.yudao.module.member.dal.dataobject.user.MemberUserDO;
+import cn.iocoder.yudao.module.member.dal.mysql.user.MemberUserMapper;
+import cn.iocoder.yudao.module.member.service.auth.MemberAuthServiceImpl;
+import cn.iocoder.yudao.module.system.api.sms.SmsCodeApi;
+import org.junit.jupiter.api.Test;
+import org.springframework.boot.test.mock.mockito.MockBean;
+import org.springframework.context.annotation.Import;
+import org.springframework.data.redis.core.StringRedisTemplate;
+import org.springframework.security.crypto.password.PasswordEncoder;
+
+import javax.annotation.Resource;
+import java.io.ByteArrayInputStream;
+import java.util.function.Consumer;
+
+import static cn.hutool.core.util.RandomUtil.*;
+import static cn.iocoder.yudao.framework.test.core.util.RandomUtils.randomPojo;
+import static cn.iocoder.yudao.framework.test.core.util.RandomUtils.randomString;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.Mockito.eq;
+import static org.mockito.Mockito.when;
+
+// TODO @芋艿：单测的 review，等逻辑都达成一致后
+/**
+ * {@link MemberUserServiceImpl} 的单元测试类
+ *
+ * @author 宋天
+ */
+@Import({MemberUserServiceImpl.class, YudaoRedisAutoConfiguration.class})
+public class MemberUserServiceImplTest extends BaseDbAndRedisUnitTest {
+
+    @Resource
+    private MemberUserServiceImpl memberUserService;
+
+    @Resource
+    private StringRedisTemplate stringRedisTemplate;
+
+    @Resource
+    private MemberUserMapper userMapper;
+
+    @MockBean
+    private MemberAuthServiceImpl authService;
+
+    @MockBean
+    private PasswordEncoder passwordEncoder;
+
+    @MockBean
+    private SmsCodeApi smsCodeApi;
+    @MockBean
+    private FileApi fileApi;
+
+    @Test
+    public void testUpdateNickName_success(){
+        // mock 数据
+        MemberUserDO userDO = randomUserDO();
+        userMapper.insert(userDO);
+
+        // 随机昵称
+        String newNickName = randomString();
+
+        // 调用接口修改昵称
+        memberUserService.updateUserNickname(userDO.getId(),newNickName);
+        // 查询新修改后的昵称
+        String nickname = memberUserService.getUser(userDO.getId()).getNickname();
+        // 断言
+        assertEquals(newNickName,nickname);
+    }
+
+    @Test
+    public void testUpdateAvatar_success() throws Exception {
+        // mock 数据
+        MemberUserDO dbUser = randomUserDO();
+        userMapper.insert(dbUser);
+
+        // 准备参数
+        Long userId = dbUser.getId();
+        byte[] avatarFileBytes = randomBytes(10);
+        ByteArrayInputStream avatarFile = new ByteArrayInputStream(avatarFileBytes);
+        // mock 方法
+        String avatar = randomString();
+        when(fileApi.createFile(eq(avatarFileBytes))).thenReturn(avatar);
+        // 调用
+        String str = memberUserService.updateUserAvatar(userId, avatarFile);
+        // 断言
+        assertEquals(avatar, str);
+    }
+
+    @Test
+    public void updateMobile_success(){
+        // mock数据
+        String oldMobile = randomNumbers(11);
+        MemberUserDO userDO = randomUserDO();
+        userDO.setMobile(oldMobile);
+        userMapper.insert(userDO);
+
+        // TODO 芋艿：需要修复该单元测试，重构多模块带来的
+        // 旧手机和旧验证码
+//        SmsCodeDO codeDO = new SmsCodeDO();
+        String oldCode = RandomUtil.randomString(4);
+//        codeDO.setMobile(userDO.getMobile());
+//        codeDO.setCode(oldCode);
+//        codeDO.setScene(SmsSceneEnum.MEMBER_UPDATE_MOBILE.getScene());
+//        codeDO.setUsed(Boolean.FALSE);
+//        when(smsCodeService.checkCodeIsExpired(codeDO.getMobile(),codeDO.getCode(),codeDO.getScene())).thenReturn(codeDO);
+
+        // 更新手机号
+        String newMobile = randomNumbers(11);
+        String newCode = randomNumbers(4);
+        AppUserUpdateMobileReqVO reqVO = new AppUserUpdateMobileReqVO();
+        reqVO.setMobile(newMobile);
+        reqVO.setCode(newCode);
+        reqVO.setOldMobile(oldMobile);
+        reqVO.setOldCode(oldCode);
+        memberUserService.updateUserMobile(userDO.getId(),reqVO);
+
+        assertEquals(memberUserService.getUser(userDO.getId()).getMobile(),newMobile);
+    }
+
+    // ========== 随机对象 ==========
+
+    @SafeVarargs
+    private static MemberUserDO randomUserDO(Consumer<MemberUserDO>... consumers) {
+        Consumer<MemberUserDO> consumer = (o) -> {
+            o.setStatus(randomEle(CommonStatusEnum.values()).getStatus()); // 保证 status 的范围
+        };
+        return randomPojo(MemberUserDO.class, ArrayUtils.append(consumer, consumers));
+    }
+
+}
--- a/yudao-module-member/yudao-module-member-biz/src/test/resources/application-unit-test.yaml
+++ b/yudao-module-member/yudao-module-member-biz/src/test/resources/application-unit-test.yaml
@@ -0,0 +1,49 @@
+spring:
+  main:
+    lazy-initialization: true # 开启懒加载，加快速度
+    banner-mode: off # 单元测试，禁用 Banner
+
+--- #################### 数据库相关配置 ####################
+
+spring:
+  # 数据源配置项
+  datasource:
+    name: ruoyi-vue-pro
+    url: jdbc:h2:mem:testdb;MODE=MYSQL;DATABASE_TO_UPPER=false; # MODE 使用 MySQL 模式；DATABASE_TO_UPPER 配置表和字段使用小写
+    driver-class-name: org.h2.Driver
+    username: sa
+    password:
+    druid:
+      async-init: true # 单元测试，异步初始化 Druid 连接池，提升启动速度
+      initial-size: 1 # 单元测试，配置为 1，提升启动速度
+  sql:
+    init:
+      schema-locations: classpath:/sql/create_tables.sql
+
+  # Redis 配置。Redisson 默认的配置足够使用，一般不需要进行调优
+  redis:
+    host: 127.0.0.1 # 地址
+    port: 16379 # 端口（单元测试，使用 16379 端口）
+    database: 0 # 数据库索引
+
+mybatis:
+  lazy-initialization: true # 单元测试，设置 MyBatis Mapper 延迟加载，加速每个单元测试
+
+--- #################### 定时任务相关配置 ####################
+
+--- #################### 配置中心相关配置 ####################
+
+--- #################### 服务保障相关配置 ####################
+
+# Lock4j 配置项（单元测试，禁用 Lock4j）
+
+# Resilience4j 配置项
+
+--- #################### 监控相关配置 ####################
+
+--- #################### 芋道相关配置 ####################
+
+# 芋道配置项，设置当前项目所有自定义的配置
+yudao:
+  info:
+    base-package: cn.iocoder.yudao.module
--- a/yudao-module-member/yudao-module-member-biz/src/test/resources/logback.xml
+++ b/yudao-module-member/yudao-module-member-biz/src/test/resources/logback.xml
@@ -0,0 +1,4 @@
+<configuration>
+    <!-- 引用 Spring Boot 的 logback 基础配置 -->
+    <include resource="org/springframework/boot/logging/logback/defaults.xml" />
+</configuration>
--- a/yudao-module-member/yudao-module-member-biz/src/test/resources/sql/clean.sql
+++ b/yudao-module-member/yudao-module-member-biz/src/test/resources/sql/clean.sql
@@ -0,0 +1 @@
+DELETE FROM "member_user";
--- a/yudao-module-member/yudao-module-member-biz/src/test/resources/sql/create_tables.sql
+++ b/yudao-module-member/yudao-module-member-biz/src/test/resources/sql/create_tables.sql
@@ -0,0 +1,32 @@
+CREATE TABLE IF NOT EXISTS "member_user"  (
+    "id" bigint NOT NULL GENERATED BY DEFAULT AS IDENTITY COMMENT '编号',
+    "nickname" varchar(30)  NOT NULL DEFAULT '' COMMENT '用户昵称',
+    "avatar" varchar(255)  NOT NULL DEFAULT '' COMMENT '头像',
+    "status" tinyint NOT NULL COMMENT '状态',
+    "mobile" varchar(11)  NOT NULL COMMENT '手机号',
+    "password" varchar(100)  NOT NULL DEFAULT '' COMMENT '密码',
+    "register_ip" varchar(32)  NOT NULL COMMENT '注册 IP',
+    "login_ip" varchar(50) NULL DEFAULT '' COMMENT '最后登录IP',
+    "login_date" datetime NULL DEFAULT NULL COMMENT '最后登录时间',
+    "creator" varchar(64)  NULL DEFAULT '' COMMENT '创建者',
+    "create_time" datetime NOT NULL DEFAULT CURRENT_TIMESTAMP COMMENT '创建时间',
+    "updater" varchar(64)  NULL DEFAULT '' COMMENT '更新者',
+    "update_time" datetime NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT '更新时间',
+    "deleted" bit(1) NOT NULL DEFAULT '0' COMMENT '是否删除',
+    "tenant_id" bigint not null default  '0',
+    PRIMARY KEY ("id")
+) COMMENT '会员表';
+
+-- inf 开头的 DB
+CREATE TABLE IF NOT EXISTS "inf_file" (
+    "id" varchar(188) NOT NULL,
+    "type" varchar(63) DEFAULT NULL,
+    "content" blob NOT NULL,
+    "creator" varchar(64) DEFAULT '',
+    "create_time" timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    "updater" varchar(64) DEFAULT '',
+    "update_time" timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    "deleted" bit NOT NULL DEFAULT FALSE,
+    PRIMARY KEY ("id")
+) COMMENT '文件表';
+